-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tip on YAML anchors to docs on dataset layers #2181
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Yury Fedotov <[email protected]>
layer: raw | ||
can be avoided by leveraging YAML's native syntax for anchors and aliases. | ||
See [this example from the Kedro docs](https://docs.kedro.org/en/stable/data/data_catalog_yaml_examples.html#load-multiple-datasets-with-similar-configuration-using-yaml-anchors). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that those are the docs of a separate project - I assume there's no way to link it other than through static URL?
Signed-off-by: Yury Fedotov <[email protected]>
Signed-off-by: Yury Fedotov <[email protected]>
Signed-off-by: Yury Fedotov <[email protected]>
Rendered docs: https://kedro--2181.org.readthedocs.build/projects/kedro-viz/en/2181/kedro-viz_visualisation.html#visualise-layers We can't have |
thanks @yury-fedotov for this, will review this today, and fix the linting issues ! |
metadata: | ||
kedro-viz: | ||
layer: raw | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also show the example here that you gave in the original issue on how to use it. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_raw_layer: &raw_layer
metadata:
kedro-viz:
layer: 01_raw
And then reuse it like this:
companies:
type: pandas.CSVDataset
filepath: data/01_raw/companies.csv
<<: *raw_layer
reviews:
type: pandas.CSVDataset
filepath: data/01_raw/reviews.csv
<<: *raw_layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rashidakanchwala yeah let me add this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rashidakanchwala see: 65d75fc
Signed-off-by: Yury Fedotov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks again @yury-fedotov , once we have another approval I will merge this on your behalf
Signed-off-by: rashidakanchwala <[email protected]>
Description
Closes #2127
Checklist